panbingkun commented on code in PR #46986:
URL: https://github.com/apache/spark/pull/46986#discussion_r1650264876
##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -83,7 +83,7 @@ private[spark] class Executor(
extends Logging {
logInfo(log"Starting executor ID ${LogMDC(LogKeys.EXECUTOR_ID, executorId)}"
+
- log" on host ${LogMDC(HOST_NAME, executorHostname)}")
+ log" on host ${LogMDC(HOST, executorHostname)}")
Review Comment:
Let's unify it as `HOST`, the general rule is
HOST: Only `host name`, not including `port`, eg: host_name
Port: Just the `port`, eg: 10240
HOST_PORT: includes both host name and port, eg: `host_name:10240`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
