cloud-fan commented on code in PR #40089:
URL: https://github.com/apache/spark/pull/40089#discussion_r1650654383
##########
connector/connect/server/src/test/scala/org/apache/spark/sql/connect/ProtoToParsedPlanTestSuite.scala:
##########
@@ -115,7 +116,7 @@ class ProtoToParsedPlanTestSuite extends SparkFunSuite with
SharedSparkSession {
val planner = new SparkConnectPlanner(spark)
val catalystPlan =
analyzer.executeAndCheck(planner.transformRelation(relation), new
QueryPlanningTracker)
- val actual = normalizeExprIds(catalystPlan).treeString
+ val actual =
normalizeExprIds(ReplaceExpressions(catalystPlan)).treeString
Review Comment:
Also for testing, I think it's good enough to verify the analyzed plan of
Spark Connect.
Also cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
