stefankandic commented on code in PR #47059:
URL: https://github.com/apache/spark/pull/47059#discussion_r1650926128
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala:
##########
@@ -223,12 +223,6 @@ trait FileFormat {
*/
def fileConstantMetadataExtractors: Map[String, PartitionedFile => Any] =
FileFormat.BASE_METADATA_EXTRACTORS
-
- /**
- * Returns whether the file format supports filter push down
- * for non utf8 binary collated columns.
- */
- def supportsCollationPushDown: Boolean = false
Review Comment:
We used this flag to determine whether to push filters with collations to
the data source, but since we added the logic for widening this no longer makes
sense. I just reverted to the old logic which just checked for determinism of
the filters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
