amaliujia commented on code in PR #47185:
URL: https://github.com/apache/spark/pull/47185#discussion_r1663459563
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTE.scala:
##########
@@ -140,26 +140,31 @@ case class InlineCTE(
cteMap: mutable.Map[Long, CTEReferenceInfo]): LogicalPlan = {
plan match {
case WithCTE(child, cteDefs) =>
- val notInlined = mutable.ArrayBuffer.empty[CTERelationDef]
- cteDefs.foreach { cteDef =>
+ val notInlined = cteDefs.map {cteDef =>
Review Comment:
yeah sure done!
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTE.scala:
##########
@@ -140,26 +140,31 @@ case class InlineCTE(
cteMap: mutable.Map[Long, CTEReferenceInfo]): LogicalPlan = {
plan match {
case WithCTE(child, cteDefs) =>
- val notInlined = mutable.ArrayBuffer.empty[CTERelationDef]
- cteDefs.foreach { cteDef =>
+ val notInlined = cteDefs.map {cteDef =>
Review Comment:
Good point :) I was confused myself somewhat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
