rgommers commented on PR #47083: URL: https://github.com/apache/spark/pull/47083#issuecomment-2206029485
@codesorcery @HyukjinKwon I noticed that a review comment here said `np.set_printoptions` is used in the tests and can be updated, but this PR uses it in `pyspark/core/` rather than in tests. `np.set_printoptions` changes global state within numpy, and doing that from within another library is a big no-no usually. Could you please consider changing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
