anishshri-db commented on code in PR #47107:
URL: https://github.com/apache/spark/pull/47107#discussion_r1664890808
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateEncoder.scala:
##########
@@ -147,35 +147,55 @@ class PrefixKeyScanStateEncoder(
// Reusable objects
private val joinedRowOnKey = new JoinedRow()
- override def encodeKey(row: UnsafeRow): Array[Byte] = {
+ override def encodeKey(row: UnsafeRow, vcfId: Option[Short]): Array[Byte] = {
+ val hasVirtualColFamilyPrefix: Boolean = vcfId.isDefined
val prefixKeyEncoded = encodeUnsafeRow(extractPrefixKey(row))
val remainingEncoded = encodeUnsafeRow(remainingKeyProjection(row))
+ val offSetForColFamilyPrefix =
Review Comment:
This function seems repeated right ? can we just put it in the base class
maybe ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
