anishshri-db commented on code in PR #47107:
URL: https://github.com/apache/spark/pull/47107#discussion_r1664948240
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala:
##########
@@ -918,6 +918,297 @@ class RocksDBStateStoreSuite extends
StateStoreSuiteBase[RocksDBStateStoreProvid
}
}
+ /* Column family related tests */
+ testWithColumnFamilies("column family creation with invalid names",
+ TestWithBothChangelogCheckpointingEnabledAndDisabled) { colFamiliesEnabled
=>
+ tryWithProviderResource(
+ newStoreProvider(useColumnFamilies = colFamiliesEnabled)) { provider =>
+ val store = provider.getStore(0)
+
+ Seq("default", "", " ", " ", " default", " default ").foreach {
colFamilyName =>
+ val ex = intercept[SparkUnsupportedOperationException] {
+ store.createColFamilyIfAbsent(colFamilyName,
+ keySchema, valueSchema, NoPrefixKeyStateEncoderSpec(keySchema))
+ }
+
+ if (!colFamiliesEnabled) {
+ checkError(
+ ex,
+ errorClass = "STATE_STORE_UNSUPPORTED_OPERATION",
+ parameters = Map(
+ "operationType" -> "create_col_family",
+ "entity" -> "multiple column families disabled in
RocksDBStateStoreProvider"
+ ),
+ matchPVals = true
+ )
+ } else {
+ checkError(
+ ex,
+ errorClass =
"STATE_STORE_CANNOT_USE_COLUMN_FAMILY_WITH_INVALID_NAME",
+ parameters = Map(
+ "operationName" -> "create_col_family",
+ "colFamilyName" -> colFamilyName
+ ),
+ matchPVals = true
+ )
+ }
+ }
+ }
+ }
+
+ testWithColumnFamilies(s"column family creation with reserved chars",
+ TestWithBothChangelogCheckpointingEnabledAndDisabled) { colFamiliesEnabled
=>
+ tryWithProviderResource(
+ newStoreProvider(useColumnFamilies = colFamiliesEnabled)) { provider =>
+ val store = provider.getStore(0)
+
+ Seq("_internal", "_test", "_test123", "__12345").foreach { colFamilyName
=>
+ val ex = intercept[SparkUnsupportedOperationException] {
+ store.createColFamilyIfAbsent(colFamilyName,
+ keySchema, valueSchema, NoPrefixKeyStateEncoderSpec(keySchema))
+ }
+
+ if (!colFamiliesEnabled) {
+ checkError(
+ ex,
+ errorClass = "STATE_STORE_UNSUPPORTED_OPERATION",
+ parameters = Map(
+ "operationType" -> "create_col_family",
+ "entity" -> "multiple column families disabled in
RocksDBStateStoreProvider"
+ ),
+ matchPVals = true
+ )
+ } else {
+ checkError(
+ ex,
+ errorClass =
"STATE_STORE_CANNOT_CREATE_COLUMN_FAMILY_WITH_RESERVED_CHARS",
+ parameters = Map(
+ "colFamilyName" -> colFamilyName
+ ),
+ matchPVals = true
+ )
+ }
+ }
+ }
+ }
+
+ testWithColumnFamilies(s"operations on absent column family",
+ TestWithBothChangelogCheckpointingEnabledAndDisabled) { colFamiliesEnabled
=>
+ tryWithProviderResource(
+ newStoreProvider(useColumnFamilies = colFamiliesEnabled)) { provider =>
+ val store = provider.getStore(0)
+
+ val colFamilyName = "test"
+
+ verifyStoreOperationUnsupported("put", colFamiliesEnabled,
colFamilyName) {
+ store.put(dataToKeyRow("a", 1), dataToValueRow(1), colFamilyName)
+ }
+
+ verifyStoreOperationUnsupported("remove", colFamiliesEnabled,
colFamilyName) {
+ store.remove(dataToKeyRow("a", 1), colFamilyName)
+ }
+
+ verifyStoreOperationUnsupported("get", colFamiliesEnabled,
colFamilyName) {
+ store.get(dataToKeyRow("a", 1), colFamilyName)
+ }
+
+ verifyStoreOperationUnsupported("iterator", colFamiliesEnabled,
colFamilyName) {
+ store.iterator(colFamilyName)
+ }
+
+ verifyStoreOperationUnsupported("merge", colFamiliesEnabled,
colFamilyName) {
+ store.merge(dataToKeyRow("a", 1), dataToValueRow(1), colFamilyName)
+ }
+
+ verifyStoreOperationUnsupported("prefixScan", colFamiliesEnabled,
colFamilyName) {
+ store.prefixScan(dataToKeyRow("a", 1), colFamilyName)
+ }
+ }
+ }
+
+ // TODO SPARK-48796 after restart state id will not be the same
Review Comment:
yea thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
