grundprinzip commented on code in PR #30:
URL: https://github.com/apache/spark-connect-go/pull/30#discussion_r1666559602
##########
spark/sql/session/sparksession.go:
##########
@@ -41,6 +42,7 @@ func NewSessionBuilder() *SparkSessionBuilder {
type SparkSessionBuilder struct {
connectionString string
+ channelBuilder channel.Builder
Review Comment:
I don't think I agree. The overall behavior of the `Builder` interaction is
that you can call `Build` to get a fresh `grpc.Conn`, but otherwise, I don't
think there are any expectations around whether the builder needs to be fresh
or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
