JoshRosen commented on code in PR #47192:
URL: https://github.com/apache/spark/pull/47192#discussion_r1667099209
##########
core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala:
##########
@@ -111,8 +113,14 @@ class TaskMetrics private[spark] () extends Serializable {
* across all such data structures created in this task. For SQL jobs, this
only tracks all
* unsafe operators and ExternalSort.
*/
+ // TODO: SPARK-48789: the naming is confusing since this does not really
reflect the whole
Review Comment:
Given that `TaskMetrics` is marked as `@DeveloperAPI`, I think we should
also add Scaladoc API docs for the two new `Peak*ExecutionMemory` metrics. We
might also want to explicitly call out in the `peakExecutionMemory` API doc
that it is _not_ equal to the sum of the other two metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
