huaxingao commented on code in PR #47233:
URL: https://github.com/apache/spark/pull/47233#discussion_r1667732253
##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -4136,6 +4136,26 @@ class Dataset[T] private[sql](
new MergeIntoWriter[T](table, this, condition)
}
+ def update(set: Map[String, Column], where: Column): Unit = {
Review Comment:
nit: for method parameter names, shall we use
```
def update(assignments:Map[String, Column], condition: Column
```
to be consistent with the `UpdateTable` logical plan and also the
`mergeInto` API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
