uros-db commented on code in PR #46761:
URL: https://github.com/apache/spark/pull/46761#discussion_r1668308768
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java:
##########
@@ -458,7 +491,7 @@ private static UTF8String lowerCaseCodePointsSlow(final
UTF8String target) {
String targetString = target.toValidString();
StringBuilder sb = new StringBuilder();
for (int i = 0; i < targetString.length(); ++i) {
- lowercaseCodePoint(targetString.codePointAt(i), sb);
+ appendLowercaseCodePoint(targetString.codePointAt(i), sb);
Review Comment:
note to self: we should use UTF8String iterator here instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
