Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6532#issuecomment-107241920
As an experiment, I put together some code to run the PySpark test suite
through `coverage.py` (https://gist.github.com/JoshRosen/60d590b1cdc271d332e5)
and it turns out that line + branch coverage for the `DecimalType` class itself
doesn't uncover this bug since it won't catch the fact that the constructor is
only ever called with defaults for both of its arguments. The closest thing to
a red flag in the coverage report was the fact that the only call to
DecimalType with arguments, inside of `_parse_datatype_json_value`, wasn't hit
by the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
