ericm-db commented on code in PR #47104:
URL: https://github.com/apache/spark/pull/47104#discussion_r1670829161
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -278,16 +282,45 @@ case class StateStoreCustomTimingMetric(name: String,
desc: String) extends Stat
SQLMetrics.createTimingMetric(sparkContext, desc)
}
-sealed trait KeyStateEncoderSpec
+sealed trait KeyStateEncoderSpec {
+ def jsonValue: JValue
+ def json: String = compact(render(jsonValue))
+}
-case class NoPrefixKeyStateEncoderSpec(keySchema: StructType) extends
KeyStateEncoderSpec
+object KeyStateEncoderSpec {
+ def fromJson(keySchema: StructType, m: Map[String, Any]):
KeyStateEncoderSpec = {
+ // match on type
+ m("keyStateEncoderType").asInstanceOf[String] match {
Review Comment:
I think that I prefer to leave it like this, if that's okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
