dongjoon-hyun commented on code in PR #43503: URL: https://github.com/apache/spark/pull/43503#discussion_r1671300283
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/xml/StaxXmlGenerator.scala: ########## @@ -16,164 +16,201 @@ */ package org.apache.spark.sql.catalyst.xml +import java.io.Writer import java.sql.Timestamp -import javax.xml.stream.XMLStreamWriter +import javax.xml.stream.XMLOutputFactory import scala.collection.Map +import com.sun.xml.txw2.output.IndentingXMLStreamWriter Review Comment: Hi, @sandip-db and @HyukjinKwon . Sorry for asking this question, but is this inevitable? This looks like the only instance importing `com.sun.*` in Apache Spark repository and which is added at Apache Spark 4.0.0-preview1. ``` $ git grep com.sun | grep import sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/xml/StaxXmlGenerator.scala:import com.sun.xml.txw2.output.IndentingXMLStreamWriter ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
