HyukjinKwon commented on code in PR #47281: URL: https://github.com/apache/spark/pull/47281#discussion_r1675167664
########## sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala: ########## @@ -113,6 +114,8 @@ class SparkSession private( private[sql] val sessionUUID: String = UUID.randomUUID.toString + var jobArtifactState: JobArtifactState = JobArtifactState(sessionUUID, None) Review Comment: I think the session state should be immutable. Can we refactor whole things to here? Basically we need to move things `JobArtifactSet` to here. Should probably leverage `InheritableThreadLocal`. Now `JobArtifactSet` works as a threadlocal. If we want the proper inheritance between sessions, should probably use `InheritableThreadLocal`. I think we really need a design here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
