LuciferYang commented on code in PR #47293:
URL: https://github.com/apache/spark/pull/47293#discussion_r1675341063
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala:
##########
@@ -100,8 +100,9 @@ abstract class HiveComparisonTest extends SparkFunSuite
with BeforeAndAfterAll {
.map(name => new File(targetDir, s"$suiteName.$name"))
/** The local directory with cached golden answer will be stored. */
- protected val answerCache = new File("src" + File.separator + "test" +
- File.separator + "resources" + File.separator + "golden")
+ private val answerCache = getWorkspaceFilePath(
Review Comment:
I think we should not change the visibility of this function.
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala:
##########
@@ -708,7 +715,7 @@ class HiveQuerySuite extends HiveComparisonTest with
SQLTestUtils with BeforeAnd
}
}
- def isExplanation(result: DataFrame): Boolean = {
+ private def isExplanation(result: DataFrame): Boolean = {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
