LuciferYang commented on code in PR #47350:
URL: https://github.com/apache/spark/pull/47350#discussion_r1677495913
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetCommitterSuite.scala:
##########
@@ -116,7 +116,7 @@ class ParquetCommitterSuite extends SparkFunSuite with
SQLTestUtils
test("SPARK-48804: Fail fast on unloadable or invalid committers") {
Seq("invalid", getClass.getName).foreach { committer =>
val e = intercept[IllegalArgumentException] {
- withSQLConf(SQLConf.PARQUET_OUTPUT_COMMITTER_CLASS.key -> committer)()
+ withSQLConf(SQLConf.PARQUET_OUTPUT_COMMITTER_CLASS.key ->
committer)(())
Review Comment:
https://github.com/apache/spark/blob/9bff2c8bc5059f5be0dc6e8105c11403942a0b9f/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SQLConfHelper.scala#L38-L62
From the code, if the `conf.setConfString(k, v)` on line 54 throws an
exception, the current configuration will not be reset. Am I right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
