sandip-db commented on code in PR #47355:
URL: https://github.com/apache/spark/pull/47355#discussion_r1678084898
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -16303,7 +16303,21 @@ def from_xml(
>>> df.select(sf.from_xml(df.value, schema).alias("xml")).collect()
[Row(xml=Row(a=1))]
- Example 2: Parsing XML with :class:`ArrayType` in schema
+ Example 2: Parsing XML with a :class:`StructType` schema
Review Comment:
Also, can you please enable tests
[here](https://github.com/apache/spark/blob/master/python/pyspark/sql/tests/connect/test_connect_function.py#L1911-L1915)
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -16303,7 +16303,21 @@ def from_xml(
>>> df.select(sf.from_xml(df.value, schema).alias("xml")).collect()
[Row(xml=Row(a=1))]
- Example 2: Parsing XML with :class:`ArrayType` in schema
+ Example 2: Parsing XML with a :class:`StructType` schema
Review Comment:
Thanks for fixing this. Can you please reuse the existing jira #SPARK-45190?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
