cloud-fan commented on code in PR #47380:
URL: https://github.com/apache/spark/pull/47380#discussion_r1681413940


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -2578,6 +2578,8 @@ class Analyzer(override val catalogManager: 
CatalogManager) extends RuleExecutor
         executeSameContext(e.plan)
       }
 
+      checkAnalysis(newSubqueryPlan)

Review Comment:
   I think adjusting the rule order is probably the safest solution for now. 
The current way of resolving subquery expressions is quite fragile. Ideally we 
should recursively invoke the full analyzer only once (and must invoke once) 
for each subquery expression, instead of doing it again and again with the `if 
resolved` check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to