wayneguow commented on code in PR #47386:
URL: https://github.com/apache/spark/pull/47386#discussion_r1681545381
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/querytest/GeneratedSubquerySuite.scala:
##########
@@ -182,8 +182,11 @@ class GeneratedSubquerySuite extends
DockerJDBCIntegrationSuite with QueryGenera
} else {
Review Comment:
Oh, sorry, I didn't make it clear, I meant in line359-362,
`for {
subqueryOperator <- subqueryOperators
isDistinct <- distinctChoices(subqueryOperator)
}`
add another axis about `correlationConditions` here to cover all the
different predicates, not only hardcoded about `=` in `generateQuery` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
