zhengruifeng commented on code in PR #47385:
URL: https://github.com/apache/spark/pull/47385#discussion_r1681920226
##########
python/pyspark/pandas/resample.py:
##########
@@ -130,19 +130,6 @@ def _resamplekey_type(self) -> DataType:
def _agg_columns_scols(self) -> List[Column]:
return [s.spark.column for s in self._agg_columns]
- def get_make_interval( # type: ignore[return]
Review Comment:
some units was ignored due to not invoked at that time, I am adding them
back to make the helper function cover all pandas units :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
