panbingkun commented on code in PR #47401:
URL: https://github.com/apache/spark/pull/47401#discussion_r1682470669
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollationRegexpExpressionsSuite.scala:
##########
@@ -120,50 +121,84 @@ class CollationRegexpExpressionsSuite extends
SparkFunSuite with ExpressionEvalH
}
test("MultiLikeBase regexp expressions with collated strings") {
- val nullStr = Literal.create(null, StringType)
- // Supported collations (StringTypeBinaryLcase)
- val binaryCollation =
StringType(CollationFactory.collationNameToId("UTF8_BINARY"))
- val lowercaseCollation =
StringType(CollationFactory.collationNameToId("UTF8_LCASE"))
// LikeAll
Review Comment:
Although the following modifications are not related to this PR, they are
only made to maintain consistency with the rest of the checks in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
