cloud-fan commented on code in PR #45234:
URL: https://github.com/apache/spark/pull/45234#discussion_r1684094611
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala:
##########
@@ -47,6 +47,15 @@ import org.apache.spark.util.random.XORShiftRandom
*/
trait ShuffleExchangeLike extends Exchange {
+ /**
+ * The asynchronous job that materializes the shuffle. It also does the
preparations work,
+ * such as waiting for the subqueries.
+ */
+ @transient private lazy val shuffleFuture: Future[MapOutputStatistics] =
executeQuery {
+ materializationStarted.set(true)
Review Comment:
Further more, I don't think this idea works. Let's say when we want to
cancel a query stage and the `materializationStarted` flag is false, we decide
to skip the cancellation but maybe the next second the `materializationStarted`
becomes true and we miss to cancel the shuffle job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
