davidm-db commented on code in PR #47403:
URL: https://github.com/apache/spark/pull/47403#discussion_r1684111561
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreter.scala:
##########
@@ -70,14 +71,22 @@ case class SqlScriptingInterpreter() {
}
val dropVariables = variables
.map(varName => DropVariable(varName, ifExists = true))
- .map(new SingleStatementExec(_, Origin(), isInternal = true))
+ .map(new SingleStatementExec(_, Origin(), isInternal = true,
collectResult = false))
.reverse
new CompoundBodyExec(
- body.collection.map(st => transformTreeIntoExecutable(st)) ++
dropVariables)
+ body.collection.map(st => transformTreeIntoExecutable(st)) ++
dropVariables, session)
case sparkStatement: SingleStatement =>
new SingleStatementExec(
sparkStatement.parsedPlan,
sparkStatement.origin,
isInternal = false)
}
+
+ def execute(executionPlan: Iterator[CompoundStatementExec]):
Iterator[Array[Row]] = {
Review Comment:
I would maybe make `buildExecutionPlan` private, and than call it from
`execute` - seems like we will never need to call `buildExecutionPlan` from
outside?
for example, if we add separate `execute*` function in the future, it can
also call `buildExecutionPlan` internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
