anishshri-db commented on code in PR #47445:
URL: https://github.com/apache/spark/pull/47445#discussion_r1687054341
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateSchemaCompatibilityChecker.scala:
##########
@@ -219,7 +222,8 @@ object StateSchemaCompatibilityChecker {
stateSchemaVersion: Int,
extraOptions: Map[String, String] = Map.empty,
storeName: String = StateStoreId.DEFAULT_STORE_NAME,
- schemaFilePath: Option[Path] = None): StateSchemaValidationResult = {
+ oldSchemaFilePath: Option[Path] = None,
Review Comment:
Lets update the comments above ?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateSchemaCompatibilityChecker.scala:
##########
@@ -185,7 +188,7 @@ class StateSchemaCompatibilityChecker(
new Path(new Path(storeCpLocation, "_metadata"), "schema")
}
-object StateSchemaCompatibilityChecker {
+object StateSchemaCompatibilityChecker extends Logging {
Review Comment:
Do we need to extend here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
