wayneguow commented on code in PR #47458:
URL: https://github.com/apache/spark/pull/47458#discussion_r1687498861
##########
connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/SchemaConverters.scala:
##########
@@ -176,16 +176,16 @@ object SchemaConverters extends Logging {
}
case MESSAGE =>
// If the `recursive.fields.max.depth` value is not specified, it will
default to -1,
- // and recursive fields are not permitted. Setting it to 0 drops all
recursive fields,
- // 1 allows it to be recursed once, and 2 allows it to be recursed
twice and so on.
- // A value greater than 10 is not allowed, and if a protobuf record
has more depth for
- // recursive fields than the allowed value, it will be truncated and
some fields may be
- // discarded.
+ // and recursive fields are not permitted. Setting it to 1 drops all
recursive fields,
+ // 2 allows it to be recursed once, and 3 allows it to be recursed
twice and so on.
+ // A value less than or equal to 0 or greater than 10 is not allowed,
and if a protobuf
+ // record has more depth for recursive fields than the allowed value,
it will be truncated
+ // and some fields may be discarded.
// SQL Schema for protob2uf `message Person { string name = 1; Person
bff = 2;}`
// will vary based on the value of "recursive.fields.max.depth".
Review Comment:
Current code implementation as below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
