LuciferYang commented on code in PR #47459:
URL: https://github.com/apache/spark/pull/47459#discussion_r1687665120
##########
connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/package.scala:
##########
@@ -17,5 +17,4 @@
package org.apache.spark.sql
package object protobuf {
Review Comment:
There are other empty `package object` definitions within the Spark internal
code, such as
https://github.com/apache/spark/blob/285489b0225004e918b6e937f7367e492292815e/streaming/src/main/scala/org/apache/spark/streaming/dstream/package.scala#L18-L24
and
https://github.com/apache/spark/blob/285489b0225004e918b6e937f7367e492292815e/core/src/main/scala/org/apache/spark/util/random/package.scala#L18-L23
Therefore, in this PR, only the definition of ·ScalaReflectionLock· was
removed while the package object `protobuf` was retained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
