zhengruifeng commented on code in PR #47464:
URL: https://github.com/apache/spark/pull/47464#discussion_r1689133124
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -767,6 +771,7 @@ object FunctionRegistry {
expression[EqualNull]("equal_null"),
expression[HllSketchEstimate]("hll_sketch_estimate"),
expression[HllUnion]("hll_union"),
+ expression[UnwrapUDT]("unwrap_udt"),
Review Comment:
`unwrap_udt` is also ML-specific
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -519,6 +519,8 @@ object FunctionRegistry {
expressionBuilder("mode", ModeBuilder),
expression[HllSketchAgg]("hll_sketch_agg"),
expression[HllUnionAgg]("hll_union_agg"),
+ expression[Product]("product"),
+ expression[CollectTopK]("collect_top_k"),
Review Comment:
`collect_top_k` is a ML-specific expression for now, I think we should not
expose it here.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -519,6 +519,8 @@ object FunctionRegistry {
expressionBuilder("mode", ModeBuilder),
expression[HllSketchAgg]("hll_sketch_agg"),
expression[HllUnionAgg]("hll_union_agg"),
+ expression[Product]("product"),
Review Comment:
I remember there was some reason to not add `product` here @cloud-fan
https://github.com/apache/spark/pull/38915#discussion_r1039400753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
