bozhang2820 commented on code in PR #46302:
URL: https://github.com/apache/spark/pull/46302#discussion_r1689320606
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala:
##########
@@ -177,7 +177,9 @@ object SQLExecution extends Logging {
shuffleIds.foreach { shuffleId =>
queryExecution.shuffleCleanupMode match {
case RemoveShuffleFiles =>
- SparkEnv.get.shuffleManager.unregisterShuffle(shuffleId)
+ // Do not unregister the shuffle on MapOutputTracker here to
trigger stage retry.
+ // Otherwise, downstream tasks will fail with
MetadataFetchFailedException.
+ sc.shuffleDriverComponents.removeShuffle(shuffleId,
Utils.isTesting)
Review Comment:
The unit tests would be flaky if we use false here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
