yaooqinn commented on code in PR #47469:
URL: https://github.com/apache/spark/pull/47469#discussion_r1689638594
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -215,9 +215,9 @@ statement
routineCharacteristics
RETURN (query | expression)
#createUserDefinedFunction
| DROP TEMPORARY? FUNCTION (IF EXISTS)? identifierReference
#dropFunction
- | DECLARE (OR REPLACE)? VARIABLE?
+ | DECLARE (OR REPLACE)? (VARIABLE | VAR)?
Review Comment:
Instead of creating a common parser, using a lexer `VARIABLE: 'VARIABLE' |
'VAR';` shall be better. Because a common parser can still be misused in the
future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
