zedtang commented on code in PR #47301:
URL: https://github.com/apache/spark/pull/47301#discussion_r1690053468
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala:
##########
@@ -209,10 +221,26 @@ object ClusterBySpec {
normalizeClusterBySpec(schema, clusterBySpec, resolver).toJson
}
+ /**
+ * Converts a ClusterBySpec to a clustering column property map entry,
without validating
+ * the column names against the schema.
+ *
+ * @param clusterBySpec existing ClusterBySpec to be converted to properties.
+ * @return a map entry for the clustering column property.
+ */
+ def toPropertyWithoutValidation(clusterBySpec: ClusterBySpec): (String,
String) = {
+ val columnValue =
mapper.writeValueAsString(clusterBySpec.columnNames.map(_.fieldNames))
Review Comment:
Yeah, you're right. Updated
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala:
##########
@@ -1373,6 +1373,65 @@ abstract class DDLSuite extends QueryTest with
DDLSuiteBase {
}
}
+ test("Clustering columns should match when appending to existing data source
tables") {
Review Comment:
sure, moved there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
