anishshri-db commented on code in PR #47475:
URL: https://github.com/apache/spark/pull/47475#discussion_r1690659089
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -881,7 +862,8 @@ object StateStore extends Logging {
case NonFatal(e) =>
logWarning(log"Error managing
${MDC(LogKeys.STATE_STORE_PROVIDER, provider)}, " +
log"stopping management thread", e)
- threadPoolException.set(e)
Review Comment:
We should probably note that the side effect of this is that an exception
being triggered will cause an unload on the partition only when that partition
detects the error and not before.
So its a tradeoff:
- if the exception is specific to the partition, we don't penalize other
partitions (potentially from separate queries)
- if the exception does apply in general, then each partition would need to
see it for the unload to be triggered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
