dongjoon-hyun commented on code in PR #23:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/23#discussion_r1690845284
##########
spark-operator/src/main/java/org/apache/spark/k8s/operator/config/SparkOperatorConf.java:
##########
@@ -226,9 +226,9 @@ public class SparkOperatorConf {
.defaultValue(-1)
.build();
- public static final ConfigOption<Integer> RETRY_MAX_ATTEMPTS =
+ public static final ConfigOption<Integer> API_RETRY_MAX_ATTEMPTS =
ConfigOption.<Integer>builder()
- .key("spark.kubernetes.operator.retry.maxAttempts")
+ .key("spark.kubernetes.operator.api.retryMaxAttempts")
Review Comment:
New namespace `spark.kubernetes.operator.api` could be misleading.
This is the backend K8s API-related configurations, right? If then, can we
rename this more specifically in order to leave a room for `Apache Spark
Kubernetes Operator`'s API-related configurations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
