anishshri-db commented on code in PR #47508:
URL: https://github.com/apache/spark/pull/47508#discussion_r1693685832
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala:
##########
@@ -441,6 +451,66 @@ case class TransformWithStateExec(
new Path(new Path(storeNamePath, "_metadata"), "schema")
}
+ private def checkOperatorPropEquality[T](
+ fieldName: String,
+ oldMetadataV2: OperatorStateMetadataV2,
+ newMetadataV2: OperatorStateMetadataV2): Unit = {
+ val oldJsonString = oldMetadataV2.operatorPropertiesJson
+ val newJsonString = newMetadataV2.operatorPropertiesJson
+ // verify that timeMode, outputMode are the same
+ implicit val formats: DefaultFormats.type = DefaultFormats
+ val oldJsonProps = JsonMethods.parse(oldJsonString).extract[Map[String,
Any]]
+ val newJsonProps = JsonMethods.parse(newJsonString).extract[Map[String,
Any]]
+ val oldProp = oldJsonProps(fieldName).asInstanceOf[T]
+ val newProp = newJsonProps(fieldName).asInstanceOf[T]
+ if (oldProp != newProp) {
+ throw StateStoreErrors.invalidConfigChangedAfterRestart(
+ fieldName,
+ oldProp.toString,
+ newProp.toString
+ )
+ }
+ }
+
+ private def checkStateVariableEquality(oldMetadataV2:
OperatorStateMetadataV2): Unit = {
+ val oldJsonString = oldMetadataV2.operatorPropertiesJson
+ implicit val formats: DefaultFormats.type = DefaultFormats
+ val oldJsonProps = JsonMethods.parse(oldJsonString).extract[Map[String,
Any]]
+ // compare state variable infos
+ val oldStateVariableInfos = oldJsonProps("stateVariables").
+ asInstanceOf[List[Map[String, Any]]]
+ .map(TransformWithStateVariableInfo.fromMap)
+ val newStateVariableInfos = getStateVariableInfos()
+ oldStateVariableInfos.foreach { oldInfo =>
+ val newInfo = newStateVariableInfos.get(oldInfo.stateName)
+ newInfo match {
+ case Some(stateVarInfo) =>
+ if (oldInfo.stateVariableType != stateVarInfo.stateVariableType) {
+ throw StateStoreErrors.invalidVariableTypeChange(
+ stateVarInfo.stateName,
+ oldInfo.stateVariableType.toString,
+ stateVarInfo.stateVariableType.toString
+ )
+ }
+ case None =>
+ }
+ }
+ }
+
+ override def validateNewMetadata(
+ oldMetadata: OperatorStateMetadata,
Review Comment:
nit: lets say `oldOperatorMetadata` and `newOperatorMetadata` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
