LuciferYang commented on code in PR #47515:
URL: https://github.com/apache/spark/pull/47515#discussion_r1694867937
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/SupportsPartitionManagementSuite.scala:
##########
@@ -248,7 +266,10 @@ class SupportsPartitionManagementSuite extends
SparkFunSuite {
test("truncatePartition") {
val table = catalog.loadTable(ident)
val partTable = new InMemoryPartitionTable(
- table.name(), table.schema(), table.partitioning(), table.properties())
+ table.name(),
Review Comment:
Would it be better to add a constructor to `InMemoryPartitionTable`? Also,
since `InMemoryPartitionTable` is code used for testing, it might be acceptable
to directly modify the default constructor definition, but I'm not sure if
there are third-party projects that depend on this test code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
