HyukjinKwon commented on code in PR #47164: URL: https://github.com/apache/spark/pull/47164#discussion_r1695312108
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala: ########## @@ -58,6 +58,8 @@ case class ScalaUDF( override lazy val deterministic: Boolean = udfDeterministic && children.forall(_.deterministic) + override lazy val foldable: Boolean = deterministic && children.forall(_.foldable) Review Comment: Or, if the UDF runs something very heavy, it will stop the Catalyst optimizer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
