cloud-fan commented on code in PR #47514: URL: https://github.com/apache/spark/pull/47514#discussion_r1695357490
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/urlExpressions.scala: ########## @@ -86,16 +86,18 @@ case class UrlEncode(child: Expression) since = "3.4.0", group = "url_funcs") // scalastyle:on line.size.limit -case class UrlDecode(child: Expression) +case class UrlDecode(child: Expression, failOnError: Boolean = true) Review Comment: can we try both SQL and DataFrame queries that invoke this SQL function, and check if the auto-generated alias name is changed after adding this new parameter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
