HeartSaVioR commented on code in PR #47475:
URL: https://github.com/apache/spark/pull/47475#discussion_r1696306747
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala:
##########
@@ -50,6 +50,38 @@ import org.apache.spark.tags.ExtendedSQLTest
import org.apache.spark.unsafe.types.UTF8String
import org.apache.spark.util.Utils
+// MaintenanceErrorOnCertainPartitionsProvider is a test-only provider that
throws an
+// exception during maintenance for partitions 0 and 1 (these are arbitrary
choices). It is
+// used to test that an exception in a single provider's maintenance does not
affect other
+// providers that do not experience exceptions.
+class MaintenanceErrorOnCertainPartitionsProvider extends
HDFSBackedStateStoreProvider {
+ private var id: StateStoreId = null
+
+ override def init(
+ stateStoreId: StateStoreId,
Review Comment:
nit: 2 more spaces for params
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -881,7 +862,19 @@ object StateStore extends Logging {
case NonFatal(e) =>
logWarning(log"Error managing
${MDC(LogKeys.STATE_STORE_PROVIDER, provider)}, " +
Review Comment:
nit: While we are here, should we say "unload state store"? Unloading state
store isn't to stop maintenance but to unload store itself, and once state
store is "reloaded" we expect maintenance task to be set again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
