uros-db commented on code in PR #47482:
URL: https://github.com/apache/spark/pull/47482#discussion_r1697676630
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -498,7 +498,9 @@ object EliminateDistinct extends Rule[LogicalPlan] {
override def apply(plan: LogicalPlan): LogicalPlan =
plan.transformWithPruning(
_.containsPattern(AGGREGATE)) {
case agg: Aggregate =>
-
agg.transformExpressionsWithPruning(_.containsPattern(AGGREGATE_EXPRESSION)) {
+ val isDistinctLiteral = isDistinctLiteralAggregate(agg)
+ var replaceDistinctAggregate = false
+ val newAgg =
agg.transformExpressionsWithPruning(_.containsPattern(AGGREGATE_EXPRESSION)) {
Review Comment:
you're right, but I think I'll close this PR anyways as it's now irrelevant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
