anishshri-db commented on code in PR #47490:
URL: https://github.com/apache/spark/pull/47490#discussion_r1699076181
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/AsyncLogPurge.scala:
##########
@@ -62,6 +70,24 @@ trait AsyncLogPurge extends Logging {
}
}
+ protected def purgeOldestAsync(plan: SparkPlan): Unit = {
+ if (purgeOldestRunning.compareAndSet(false, true)) {
+ asyncPurgeExecutorService.execute(() => {
+ try {
+ purgeOldest(plan)
+ } catch {
+ case throwable: Throwable =>
+ logError("Encountered error while performing async log purge",
throwable)
+ errorNotifier.markError(throwable)
Review Comment:
Will this result in a query failure ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
