dongjoon-hyun commented on code in PR #28:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/28#discussion_r1700753231
##########
build-tools/docker/Dockerfile:
##########
@@ -0,0 +1,29 @@
+FROM gradle:8.9.0-jdk17-alpine AS builder
+ARG APP_VERSION
+WORKDIR /app
+COPY . .
+RUN ./gradlew clean build -x test
+
+FROM eclipse-temurin:17-jre-jammy
Review Comment:
I understand your intention, but it seems that we need to avoid this kind of
confusion in the community.
Specifically, what makes you think in this way? This is not aligned with
Apache Spark 4.0.0 in three ways.
> We use the latest gradle 8.9 image as builder, with
eclipse-temurin:17-jre-jammy - the latter still uses base image version 22.04
which is inline with version used in core Spark.
I guess you are confused the following three things.
- JDK is the minimum requirement instead of JRE to support the full Spark
feature.
- https://github.com/apache/spark/pull/45761
- We use `azul/zulu-openjdk` in Spark 4 instead of `eclipse-temurin`.
- https://github.com/apache/spark/pull/43048
- Lastly, SPARK-49005 is for only Spark 3.x JIRA. Please see the JIRA
information.
- https://github.com/apache/spark/pull/47488
- https://github.com/apache/spark/pull/47489
<img width="660" alt="Screenshot 2024-08-01 at 12 46 39"
src="https://github.com/user-attachments/assets/01e80474-13af-4a6c-84cb-71f59149511b";>
In other words, Apache Spark 4 is using `azul/zulu-openjdk:21`.
- Apache Spark 4.0.0-preview2
https://github.com/apache/spark/blob/7a7a8bc4bab591ac8b98b2630b38c57adf619b82/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile#L17-L19
- Apache Spark master
https://github.com/apache/spark/blob/6706c41cb42cbd270a6580385be67b2a2313df27/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile#L17-L19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
