Github user coolfrood commented on a diff in the pull request:
https://github.com/apache/spark/pull/6361#discussion_r31436871
--- Diff:
core/src/main/scala/org/apache/spark/util/SerializableBuffer.scala ---
@@ -21,12 +21,16 @@ import java.io.{EOFException, IOException,
ObjectInputStream, ObjectOutputStream
import java.nio.ByteBuffer
import java.nio.channels.Channels
+import com.esotericsoftware.kryo.{Kryo, KryoSerializable}
+import com.esotericsoftware.kryo.io.{Input, Output}
+
/**
* A wrapper around a java.nio.ByteBuffer that is serializable through
Java serialization, to make
* it easier to pass ByteBuffers in case class messages.
*/
private[spark]
-class SerializableBuffer(@transient var buffer: ByteBuffer) extends
Serializable {
+class SerializableBuffer(@transient var buffer: ByteBuffer)
+ extends Serializable with KryoSerializable {
--- End diff --
This is not necessary because Kryo will use its own serialization by
default. However, registering with Kryo saves a few bytes by not requiring the
full class name to be put in. I'll add it to the list of registered classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
