cloud-fan commented on code in PR #47581:
URL: https://github.com/apache/spark/pull/47581#discussion_r1701960014


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4603,6 +4603,15 @@ object SQLConf {
       .booleanConf
       .createWithDefault(true)
 
+  val OPTIMIZE_BETWEEN =
+    buildConf("spark.sql.optimizeBetween")

Review Comment:
   It's not only an optimization, but also a correctness fix if the BETWEEN 
input is nondeterministic. I think a legacy config is better here. How about 
`spark.sql.legacy.duplicateBetweenInput`? By default it's false, and people can 
set it to true to restore to the legacy behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to