riyaverm-db commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704769665
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -200,8 +200,7 @@ class RocksDBFileManager(
case 2 =>
new StateStoreChangelogWriterV2(fm, changelogFile, codec)
case _ =>
- throw new IllegalArgumentException(s"Failed to find changelog writer
for " +
- s"version=$changelogVersion")
+ throw
QueryExecutionErrors.invalidChangeLogWriterVersion(changelogVersion)
Review Comment:
We can see when we call getChangeLogVersion it only returns 1 or 2 based on
a boolean useColumnFamilies. Versioning is not added to change log file format
so we cannot add this test @anishshri-db.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
