HeartSaVioR commented on code in PR #47528:
URL: https://github.com/apache/spark/pull/47528#discussion_r1704814814
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/state/metadata/StateMetadataSource.scala:
##########
@@ -207,12 +217,9 @@ class StateMetadataPartitionReader(
} else {
1
}
- OperatorStateMetadataReader.createReader(
- operatorIdPath, hadoopConf, operatorStateMetadataVersion).read() match
{
- case Some(metadata) => metadata
- case None => OperatorStateMetadataV1(OperatorInfoV1(opId, null),
- Array(StateStoreMetadataV1(null, -1, -1)))
- }
+ val reader = OperatorStateMetadataReader.createReader(
+ operatorIdPath, hadoopConf, operatorStateMetadataVersion, batchId)
+ reader.read().get
Review Comment:
What I'm specifically concerned is to call get without any error handling.
Is it expected to have exception in prior if reader.read() is None? Or what
would be the exception users will face if None.get happens here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
