Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6555#discussion_r31448748
  
    --- Diff: external/flume-sink/pom.xml ---
    @@ -85,6 +97,13 @@
               </execution>
             </executions>
           </plugin>
    +      <plugin>
    +        <groupId>org.apache.maven.plugins</groupId>
    +        <artifactId>maven-shade-plugin</artifactId>
    +        <configuration>
    +          <relocations combine.self="override" />
    +        </configuration>
    --- End diff --
    
    is it worth adding a short comment here explaining why this is necessary?  
maybe this is obvious to others more versed in maven, but it was a little 
mysterious to me.  Then again we don't doc a lot of the intricacies of the 
build system.  anyway, just a suggestion, I'll leave it up to your judgement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to