uros-db commented on code in PR #47649:
URL: https://github.com/apache/spark/pull/47649#discussion_r1707128598
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -579,6 +579,29 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPlanHelper {
}
}
+ test("SPARK-49138: ArrayAppend and CreateMap coercion testing") {
+ val df_array_append = sql(s"SELECT array_append(array('a', 'b'), 'c'
COLLATE UNICODE)")
+ // array_append expression
+ checkAnswer(df_array_append, Seq(Row(Seq("a", "b", "c"))))
+ assert(df_array_append.schema.head.dataType ==
ArrayType(StringType("UNICODE"), true))
+
+ // make sure we fail this query even when collations are in
+ checkError(
+ exception = intercept[AnalysisException] {
+ sql("select map('a' COLLATE UTF8_LCASE, 'b', 'c')")
+ },
+ errorClass = "WRONG_NUM_ARGS.WITHOUT_SUGGESTION",
+ parameters = Map("functionName" -> "`map`", "expectedNum" -> "2n (n >
0)",
+ "actualNum" -> "3", "docroot" ->
"https://spark.apache.org/docs/latest";)
+ )
+
+ // map creation keys respects proper collation
+ val df_create_map = sql("select map('a' COLLATE UTF8_LCASE, 'b', 'c',
'c')")
Review Comment:
should we also test something like:
```
sql("select map('a' COLLATE UTF8_LCASE, 'b', 'c' COLLATE UNICODE, 'c')")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
