cloud-fan commented on code in PR #47545:
URL: https://github.com/apache/spark/pull/47545#discussion_r1708996394
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InsertMapSortInGroupingExpressions.scala:
##########
@@ -17,56 +17,89 @@
package org.apache.spark.sql.catalyst.optimizer
-import org.apache.spark.sql.catalyst.expressions.{ArrayTransform,
CreateNamedStruct, Expression, GetStructField, If, IsNull, LambdaFunction,
Literal, MapFromArrays, MapKeys, MapSort, MapValues, NamedLambdaVariable}
+import scala.collection.mutable
+
+import org.apache.spark.sql.catalyst.expressions.{Alias, ArrayTransform,
CreateNamedStruct, Expression, GetStructField, If, IsNull, LambdaFunction,
Literal, MapFromArrays, MapKeys, MapSort, MapValues, NamedExpression,
NamedLambdaVariable}
import org.apache.spark.sql.catalyst.plans.logical.{Aggregate, LogicalPlan}
import org.apache.spark.sql.catalyst.rules.Rule
-import org.apache.spark.sql.catalyst.trees.TreePattern.AGGREGATE
import org.apache.spark.sql.types.{ArrayType, MapType, StructType}
import org.apache.spark.util.ArrayImplicits.SparkArrayOps
/**
- * Adds MapSort to group expressions containing map columns, as the key/value
paris need to be
+ * Adds [[MapSort]] to group expressions containing map columns, as the
key/value paris need to be
* in the correct order before grouping:
+ *
* SELECT COUNT(*) FROM TABLE GROUP BY map_column =>
* SELECT COUNT(*) FROM TABLE GROUP BY map_sort(map_column)
+ *
+ * SELECT map_column, COUNT(*) FROM TABLE GROUP BY map_column =>
+ * SELECT map_sort(map_column) as map_column, COUNT(*) FROM TABLE GROUP BY
map_sort(map_column)
+ *
+ * SELECT map_expr as c, COUNT(*) FROM TABLE GROUP BY map_expr =>
+ * SELECT map_sort(map_expr) as c, COUNT(*) FROM TABLE GROUP BY
map_sort(map_expr)
*/
object InsertMapSortInGroupingExpressions extends Rule[LogicalPlan] {
- override def apply(plan: LogicalPlan): LogicalPlan =
plan.transformWithPruning(
- _.containsPattern(AGGREGATE), ruleId) {
- case a @ Aggregate(groupingExpr, _, _) =>
- val newGrouping = groupingExpr.map { expr =>
- if (!expr.exists(_.isInstanceOf[MapSort])
- && expr.dataType.existsRecursively(_.isInstanceOf[MapType])) {
- insertMapSortRecursively(expr)
+ private def shouldAddMapSort(expr: Expression): Boolean = {
+ expr.dataType.existsRecursively(_.isInstanceOf[MapType]) &&
!expr.isInstanceOf[MapSort]
Review Comment:
think about `... GROUP BY size(map_col)`, we don't need to add `MapSort`. I
think we only need to add it when the grouping expression itself is map type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
