oliverbeagley-pgg commented on PR #47647: URL: https://github.com/apache/spark/pull/47647#issuecomment-2275652766
Sorry, I'm a random bystander who occasionally skims the commit log for new things in spark and wanders down the rabbit hole, but I've noticed that this has effectively reversed https://github.com/apache/spark/pull/47289, likely incurring the performance hit again. For the logs calling `self._proto_to_string` should this not be something like the following? ```py if logger.isEnabledFor(logging.DEBUG): logger.debug("<msg>") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
