milastdbx commented on PR #47611: URL: https://github.com/apache/spark/pull/47611#issuecomment-2277920295
> This is still unclear. Basically, your changes are trying to simply skip the potential pushdown, instead of failing the queries. However, in the test mode, we should still allow the query to fail. This will help us identify and capture any underlying bugs, rather than silently bypassing them. Ignoring these bugs could lead to missed opportunities for predicate pushdown, which might negatively impact query performance. WDYT? Agreed. Updated description and added test assert. Also refactored code to have cleaner API as per agreement with @sigmod -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
